Whole file
r1chardj0n3s/parse
The author described this change as “fix type conversion error with dotted names”. It counts as a record because the check below fails on the code as it stood at 3891beae6 and passes on 3f0bf88f8, with nothing else changed between the two runs.
Projectr1chardj0n3s/parse
Fix saved2012-09-29
Sharing licenceMIT · LICENSE
Change size+4 −3
What the code was meant to do, written into the code itself as a save note
fix type conversion error with dotted names
The change
| 236 | 236 | ||
| 237 | 237 | **Version history (in brief)**: | |
| 238 | 238 | ||
| 239 | + | - 1.5.2 fix type conversion error with dotted names (thanks Sebastian Thiel) | |
| 239 | 240 | - 1.5.1 implement handling of named datetime fields | |
| 240 | 241 | - 1.5 add handling of dotted field names (thanks Sebastian Thiel) | |
| 241 | 242 | - 1.4.1 fix parsing of "0" in int conversion (thanks James Rowe) | |
| ⋯ | |||
| 270 | 271 | This code is copyright 2011 eKit.com Inc (http://www.ekit.com/) | |
| 271 | 272 | See the end of the source file for the license of use. | |
| 272 | 273 | ''' | |
| 273 | - | __version__ = '1.5.1' | |
| 274 | + | __version__ = '1.5.2' | |
| 274 | 275 | ||
| 275 | 276 | # yes, I now have two problems | |
| 276 | 277 | import re | |
| ⋯ | |||
| 594 | 595 | for k in self._named_fields: | |
| 595 | 596 | korig = self._group_to_name_map[k] | |
| 596 | 597 | name_map[korig] = k | |
| 597 | - | if korig in self._type_conversions: | |
| 598 | - | named_fields[korig] = self._type_conversions[korig](groupdict[k], m) | |
| 598 | + | if k in self._type_conversions: | |
| 599 | + | named_fields[korig] = self._type_conversions[k](groupdict[k], m) | |
| 599 | 600 | else: | |
| 600 | 601 | named_fields[korig] = groupdict[k] | |
| 601 | 602 | ||
The check that tells the two apart
fail→pass·test_parse.py::TestBugs::test_dotted_type_conversion_pull_8
Check file test_parse.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it3891beae6c912a0ad1c398ecb49859eb5adacf37
Broken version dated2012-09-28
Moduleparse
Units changedParser
Fingerprint03d66971edbcd205
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in r1chardj0n3s/parse
- 2021-06-04Fix handling of unused alignment (#132)
- 2020-07-30findall
- 2019-12-23Handle fortran formatted float number, Bug fix & test case.
- 2013-10-15date_convert