goldset

Whole file

marcelblijleven/goodwe

The author described this change as “Fix broken settings() method on DT inverters”. It counts as a record because the check below fails on the code as it stood at 6895225c1 and passes on 8a65c18da, with nothing else changed between the two runs.

Projectmarcelblijleven/goodwe
Fix saved2023-03-31
Sharing licenceMIT · LICENSE
Change size+1 −1

What the code was meant to do, written into the code itself as a save note

Fix broken settings() method on DT inverters

The change

232232 return self._sensors
233233
234234 def settings(self) -> Tuple[Sensor, ...]:
235- return self._settings
235+ return tuple(self._settings.values())
236236

The check that tells the two apart

fail→pass·tests/test_dt.py::GW6000_DT_Test::test_GW6000_DT_setting

Check file tests/test_dt.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.

Origin and history

The fix8a65c18dab290f4c2b930a322da94a1a7bdd5172
The code before it6895225c1a7780ff960140bd2690ecf9a2f127bb
Broken version dated2023-03-31
Modulegoodwe.dt
Units changedDT
Fingerprint04e784dda0007a80
Checked2026-08-18 by goldset/0.1

Every field above is generated by our program. None of it is written by hand.

Other bugs found in marcelblijleven/goodwe