Whole file
marcelblijleven/goodwe
The author described this change as “Fix unit of current MPPT sensors”. It counts as a record because the check below fails on the code as it stood at af031d8fd and passes on bff0fef79, with nothing else changed between the two runs.
Projectmarcelblijleven/goodwe
Fix saved2023-12-31
Sharing licenceMIT · LICENSE
Change size+8 −8
What the code was meant to do, written into the code itself as a save note
Fix unit of current MPPT sensors
The change
| 312 | 312 | Power("pmppt6", 35342, "MPPT6 Power", Kind.PV), | |
| 313 | 313 | Power("pmppt7", 35343, "MPPT7 Power", Kind.PV), | |
| 314 | 314 | Power("pmppt8", 35344, "MPPT8 Power", Kind.PV), | |
| 315 | - | Power("imppt1", 35345, "MPPT1 Current", Kind.PV), | |
| 316 | - | Power("imppt2", 35346, "MPPT2 Current", Kind.PV), | |
| 317 | - | Power("imppt3", 35347, "MPPT3 Current", Kind.PV), | |
| 318 | - | Power("imppt4", 35348, "MPPT4 Current", Kind.PV), | |
| 319 | - | Power("imppt5", 35349, "MPPT5 Current", Kind.PV), | |
| 320 | - | Power("imppt6", 35350, "MPPT6 Current", Kind.PV), | |
| 321 | - | Power("imppt7", 35351, "MPPT7 Current", Kind.PV), | |
| 322 | - | Power("imppt8", 35352, "MPPT8 Current", Kind.PV), | |
| 315 | + | Current("imppt1", 35345, "MPPT1 Current", Kind.PV), | |
| 316 | + | Current("imppt2", 35346, "MPPT2 Current", Kind.PV), | |
| 317 | + | Current("imppt3", 35347, "MPPT3 Current", Kind.PV), | |
| 318 | + | Current("imppt4", 35348, "MPPT4 Current", Kind.PV), | |
| 319 | + | Current("imppt5", 35349, "MPPT5 Current", Kind.PV), | |
| 320 | + | Current("imppt6", 35350, "MPPT6 Current", Kind.PV), | |
| 321 | + | Current("imppt7", 35351, "MPPT7 Current", Kind.PV), | |
| 322 | + | Current("imppt8", 35352, "MPPT8 Current", Kind.PV), | |
| 323 | 323 | Reactive4("reactive_power1", 35353, "Reactive Power L1", Kind.GRID), | |
| 324 | 324 | Reactive4("reactive_power2", 35355, "Reactive Power L2", Kind.GRID), | |
| 325 | 325 | Reactive4("reactive_power3", 35357, "Reactive Power L3", Kind.GRID), |
The check that tells the two apart
fail→pass·tests/test_et.py::GW25K_ET_Test::test_GW25K_ET_runtime_data
Check file tests/test_et.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before itaf031d8fd1b4a630362576a7a1df049b4f0da170
Broken version dated2023-12-18
Modulegoodwe.et
Units changedET
Fingerprint04ec3490f127fc21
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in marcelblijleven/goodwe
- 2026-03-29Fix duplicate sensor registrations
- 2024-05-14Fix decoding 0 energy values
- 2024-05-12Fix writing single byte settings on ES inverters
- 2024-05-08Fix setup of BT inverters
- 2024-04-08Fix decoding of voltage values
- 2024-01-09Fix deconding 0x55 as not-set value of EcoMode