Whole file
pavdmyt/yaspin
The author described this change as “Raise ValueError when trying to register handler for SIGKILL”. It counts as a record because the check below fails on the code as it stood at b3e021679 and passes on c4a41321f, with nothing else changed between the two runs.
Projectpavdmyt/yaspin
Fix saved2018-09-03
Sharing licenceMIT · LICENSE
Change size+8 −0
What the code was meant to do, written into the code itself as a save note
Raise ValueError when trying to register handler for SIGKILL
The change
| 219 | 219 | if self._sigmap: | |
| 220 | 220 | # Register signal handlers | |
| 221 | 221 | for sig, sig_handler in iteritems(self._sigmap): | |
| 222 | + | # SIGKILL cannot be caught or ignored, and the receiving | |
| 223 | + | # process cannot perform any clean-up upon receiving this | |
| 224 | + | # signal. | |
| 225 | + | if sig == signal.SIGKILL: | |
| 226 | + | raise ValueError( | |
| 227 | + | "Registering handler for SIGKILL signal. " | |
| 228 | + | "SIGKILL cannot be cought or ignored in POSIX systems." | |
| 229 | + | ) | |
| 222 | 230 | # A handler for a particular signal, once set, remains | |
| 223 | 231 | # installed until it is explicitly reset. Store default | |
| 224 | 232 | # signal handlers for subsequent reset at cleanup phase. |
The check that tells the two apart
fail→pass·tests/test_signals.py::test_raise_exception_for_sigkill
Check file tests/test_signals.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before itb3e02167965ad570bd42c65496293528c90bc803
Broken version dated2018-08-31
Moduleyaspin.core
Units changedYaspin
Fingerprint4bf636bafec70f06
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.