One function
Conversor in renatopp/liac-arff
The author described this change as “FIX do not interpret '?' as null”. It counts as a record because the check below fails on the code as it stood at 94ef6563d and passes on 910651872, with nothing else changed between the two runs.
Projectrenatopp/liac-arff
Fix saved2017-02-01
Sharing licenceMIT · LICENSE
Change size+3 −1
What the code was meant to do, written into the code itself as a docstring
Conversor is a helper used for converting ARFF types to Python types.
The change
| 59 | 59 | This function also verify if the value is an empty string or a missing | |
| 60 | 60 | value, either cases, it returns None. | |
| 61 | 61 | ''' | |
| 62 | - | value = value.strip(' ').strip('\"\'') | |
| 62 | + | value = value.strip(' ') | |
| 63 | 63 | ||
| 64 | 64 | if value == u'?' or value == u'': | |
| 65 | 65 | return None | |
| 66 | + | ||
| 67 | + | value = value.strip('\"\'') | |
| 66 | 68 | ||
| 67 | 69 | return self._conversor(value) |
The check that tells the two apart
fail→pass·tests/test_loads.py::TestLoads::test_quoted_null
Check file tests/test_loads.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it94ef6563d8c10502f4dd62794ac920a0322d7a51
Broken version dated2017-02-01
Modulearff
Units changedConversor
Fingerprint4e57cf76d16d38f3
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in renatopp/liac-arff
- 2018-03-14FIX #61, remove trailing comment lines