Whole file
kayak/pypika
The author described this change as “BUG: fix JoinUsing get_sql”. It counts as a record because the check below fails on the code as it stood at 3f3bebd96 and passes on e436d90c7, with nothing else changed between the two runs.
Projectkayak/pypika
Fix saved2019-10-29
Sharing licenceApache-2.0 · LICENSE.txt
Change size+1 −1
What the code was meant to do, written into the code itself as a save note
BUG: fix JoinUsing get_sql
The change
| 1325 | 1325 | join_sql = super(JoinUsing, self).get_sql(**kwargs) | |
| 1326 | 1326 | return '{join} USING ({fields})'.format( | |
| 1327 | 1327 | join=join_sql, | |
| 1328 | - | fields=','.join(str(field) for field in self.fields) | |
| 1328 | + | fields=','.join(field.get_sql(**kwargs) for field in self.fields) | |
| 1329 | 1329 | ) | |
| 1330 | 1330 | ||
| 1331 | 1331 | def validate(self, _from, _joins): |
The check that tells the two apart
fail→pass·pypika/tests/test_joins.py::SelectQueryJoinTests::test_join_using_with_quote_char
Check file pypika/tests/test_joins.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it3f3bebd96f219a020553d1bd71ff07d283846e2f
Broken version dated2019-10-25
Modulepypika.queries
Units changedJoinUsing
Fingerprint7222148fb1b78c4a
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in kayak/pypika
- 2024-04-17fix `Field.__init__` (#742)
- 2023-09-26Fix: Allow the usage of `frozenset` in the `isin(...)` and `notin(...)` functions (#744)
- 2023-09-22fix(terms): fixed EmptyCriterion bug with ComplexCriterion (#732)
- 2021-08-26MySQLQuery
- 2021-01-11Fix empty Postgres array syntax (#539)
- 2021-01-04Fix PostgreSQLQueryBuilder returning clause code causing Py3.9 test failures