Whole file
wbond/asn1crypto
The author described this change as “Fix tagging for RoleSyntax and SecurityCategory”. It counts as a record because the check below fails on the code as it stood at 9ae350f21 and passes on 0e602d971, with nothing else changed between the two runs.
Projectwbond/asn1crypto
Fix saved2021-11-21
Sharing licenceMIT · LICENSE
Change size+2 −2
What the code was meant to do, written into the code itself as a save note
Fix tagging for RoleSyntax and SecurityCategory
The change
| 315 | 315 | class RoleSyntax(Sequence): | |
| 316 | 316 | _fields = [ | |
| 317 | 317 | ('role_authority', GeneralNames, {'implicit': 0, 'optional': True}), | |
| 318 | - | ('role_name', GeneralName, {'implicit': 1}), | |
| 318 | + | ('role_name', GeneralName, {'explicit': 1}), | |
| 319 | 319 | ] | |
| 320 | 320 | ||
| 321 | 321 | ||
| ⋯ | |||
| 337 | 337 | class SecurityCategory(Sequence): | |
| 338 | 338 | _fields = [ | |
| 339 | 339 | ('type', ObjectIdentifier, {'implicit': 0}), | |
| 340 | - | ('value', Any, {'implicit': 1}), | |
| 340 | + | ('value', Any, {'explicit': 1}), | |
| 341 | 341 | ] | |
| 342 | 342 | ||
| 343 | 343 | ||
The check that tells the two apart
fail→pass·tests/test_cms.py::CMSTests::test_create_role_syntax
Check file tests/test_cms.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it9ae350f212532dfee7f185f6b3eda24753249cf3
Broken version dated2021-10-15
Moduleasn1crypto.cms
Units changedRoleSyntax, SecurityCategory
Fingerprint77ccbcd71d4421b7
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in wbond/asn1crypto
- 2021-12-05Fix Clearance type definition
- 2021-08-14_parse
- 2019-09-23_dump_header
- 2017-11-28Fix type checking in pem.armor()
- 2017-02-07_parse
- 2016-03-29uri_to_iri