Whole file
omnilib/aiosqlite
The author described this change as “fix: close connection thread properly if BaseException raised in connect step (#317)”. It counts as a record because the check below fails on the code as it stood at 5391d28ac and passes on 883695fc6, with nothing else changed between the two runs.
Projectomnilib/aiosqlite
Fix saved2025-02-02
Sharing licenceMIT · LICENSE
Change size+1 −1
What the code was meant to do, written into the code itself as a save note
fix: close connection thread properly if BaseException raised in connect step (#317)
The change
| 138 | 138 | future = asyncio.get_event_loop().create_future() | |
| 139 | 139 | self._tx.put_nowait((future, self._connector)) | |
| 140 | 140 | self._connection = await future | |
| 141 | - | except Exception: | |
| 141 | + | except BaseException: | |
| 142 | 142 | self._stop_running() | |
| 143 | 143 | self._connection = None | |
| 144 | 144 | raise |
The check that tells the two apart
fail→pass·aiosqlite/tests/smoke.py::SmokeTest::test_connect_base_exception
Check file aiosqlite/tests/smoke.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it5391d28ac99cf7bde07ebd923f747d2142726206
Broken version dated2025-02-02
Moduleaiosqlite.core
Units changedConnection
Fingerprint81b5a1a5364d6bec
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.