Whole file
marcelblijleven/goodwe
The author described this change as “Fix ES set_grid_export_limit”. It counts as a record because the check below fails on the code as it stood at 57e49efe9 and passes on 12995250f, with nothing else changed between the two runs.
Projectmarcelblijleven/goodwe
Fix saved2021-09-02
Sharing licenceMIT · LICENSE
Change size+1 −1
What the code was meant to do, written into the code itself as a save note
Fix ES set_grid_export_limit
The change
| 150 | 150 | async def set_grid_export_limit(self, export_limit: int): | |
| 151 | 151 | if export_limit >= 0 or export_limit <= 10000: | |
| 152 | 152 | await self._read_from_socket( | |
| 153 | - | Aa55ProtocolCommand("033502" + "{:02x}".format(export_limit), "03b5") | |
| 153 | + | Aa55ProtocolCommand("033502" + "{:04x}".format(export_limit), "03b5") | |
| 154 | 154 | ) | |
| 155 | 155 | ||
| 156 | 156 | async def set_work_mode(self, work_mode: int): |
The check that tells the two apart
fail→pass·tests/test_es.py::EsProtocolTest::test_set_grid_export_limit
Check file tests/test_es.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it57e49efe9187083f470df9b0d96264723619d0d8
Broken version dated2021-09-02
Modulegoodwe.es
Units changedES
Fingerprint8dc396d77c75e65d
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in marcelblijleven/goodwe
- 2026-03-29Fix duplicate sensor registrations
- 2024-05-14Fix decoding 0 energy values
- 2024-05-12Fix writing single byte settings on ES inverters
- 2024-05-08Fix setup of BT inverters
- 2024-04-08Fix decoding of voltage values
- 2024-01-09Fix deconding 0x55 as not-set value of EcoMode