Whole file
miguelgrinberg/python-engineio
The author described this change as “Fix incorrect disconnection reason reported when browser page is closed”. It counts as a record because the check below fails on the code as it stood at d13e9efec and passes on 132fbd9b2, with nothing else changed between the two runs.
Fix saved2024-12-29
Sharing licenceMIT · LICENSE
Change size+2 −1
What the code was meant to do, written into the code itself as a save note
Fix incorrect disconnection reason reported when browser page is closed
The change
| 250 | 250 | ||
| 251 | 251 | self.queue.put(None) # unlock the writer task so that it can exit | |
| 252 | 252 | writer_task.join() | |
| 253 | - | self.close(wait=False, abort=True) | |
| 253 | + | self.close(wait=False, abort=True, | |
| 254 | + | reason=self.server.reason.TRANSPORT_CLOSE) | |
| 254 | 255 | ||
| 255 | 256 | return [] | |
| 256 | 257 |
The check that tells the two apart
fail→pass·tests/common/test_socket.py::TestSocket::test_websocket_read_write
Check file tests/common/test_socket.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before itd13e9efec1343bb609679943a5d3ce60f8089c14
Broken version dated2024-12-24
Moduleengineio.socket
Units changedSocket
Fingerprintd762a60589310ac6
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.