goldset

Whole file

marcelblijleven/goodwe

The author described this change as “Fix decoding of e_total in DT based inverters”. It counts as a record because the check below fails on the code as it stood at ce2572601 and passes on c9d93f90d, with nothing else changed between the two runs.

Projectmarcelblijleven/goodwe
Fix saved2021-08-31
Sharing licenceMIT · LICENSE
Change size+2 −4

What the code was meant to do, written into the code itself as a save note

Fix decoding of e_total in DT based inverters

The change

7171 Integer("xx84", 84, "Unknown sensor@84"),
7272 Integer("xx86", 86, "Unknown sensor@86"),
7373 Energy("e_day", 88, "Today's PV Generation", Kind.PV),
74- Integer("xx90", 90, "Unknown sensor@90"),
75- Energy("e_total", 92, "Total PV Generation", Kind.PV),
76- Integer("xx94", 94, "Unknown sensor@94"),
77- Integer("h_total", 96, "Hours Total", "h", Kind.PV),
74+ Energy4("e_total", 90, "Total PV Generation", Kind.PV),
75+ Long("h_total", 94, "Hours Total", "h", Kind.PV),
7876 Integer("safety_country", 98, "Safety Country code", "", Kind.AC),
7977 Enum2("safety_country_label", 98, SAFETY_COUNTRIES_ET, "Safety Country", "", Kind.AC),
8078 Integer("xx100", 100, "Unknown sensor@100"),

The check that tells the two apart

fail→pass·tests/test_dt.py::DtProtocolTest::test_GW6000_DT_runtime_data

Check file tests/test_dt.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.

Origin and history

The fixc9d93f90df20dc9b33de5f63f761684ced34a5ce
The code before itce2572601d19a65b5b583dc206cd5dd8fdfcb818
Broken version dated2021-08-31
Modulegoodwe.dt
Units changedDT
Fingerprinte146cef8346a9de2
Checked2026-08-18 by goldset/0.1

Every field above is generated by our program. None of it is written by hand.

Other bugs found in marcelblijleven/goodwe