Whole file
jacobschaer/python-doipclient
The author described this change as “Fix routing activation through gateways (#76)”. It counts as a record because the checks below fail on the code as it stood at 9c25660cf and pass on bcd745cb9, with nothing else changed between the two runs.
Fix saved2026-08-17
Sharing licenceMIT · LICENSE
Change size+0 −7
What the code was meant to do, written into the code itself as a save note
Fix routing activation through gateways (#76)
The change
| 616 | 616 | ) | |
| 617 | 617 | ) | |
| 618 | 618 | continue | |
| 619 | - | if result.logical_address != self._ecu_logical_address: | |
| 620 | - | logger.warning( | |
| 621 | - | "Routing Activation Response with invalid ECU logical address, multiple ECUs detected. Expected: 0x{:04X}, Got: 0x{:04X}. Ignoring".format( | |
| 622 | - | self._ecu_logical_address, result.logical_address | |
| 623 | - | ) | |
| 624 | - | ) | |
| 625 | - | continue | |
| 626 | 619 | return result | |
| 627 | 620 | if result: | |
| 628 | 621 | logger.warning( |
The check that tells the two apart
fail→pass·tests/test_client.py::test_activation_accepts_gateway_logical_address
fail→pass·tests/test_client.py::test_activation_ignores_mismatched_client_before_accepting_gateway
Check file tests/test_client.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it9c25660cf0dc5db44c43a5c2eedf91f7f432d8b0
Broken version dated2026-05-12
Moduledoipclient.client
Units changedDoIPClient
Fingerprinte4a444fa855efdf9
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.