Whole file
kayak/pypika
The author described this change as “fix nested function as”. It counts as a record because the check below fails on the code as it stood at cce2435b1 and passes on 0e8029ac7, with nothing else changed between the two runs.
Projectkayak/pypika
Fix saved2020-04-01
Sharing licenceApache-2.0 · LICENSE.txt
Change size+1 −1
What the code was meant to do, written into the code itself as a save note
fix nested function as
The change
| 1148 | 1148 | return "{name}({args}{special})".format( | |
| 1149 | 1149 | name=self.name, | |
| 1150 | 1150 | args=",".join( | |
| 1151 | - | p.get_sql(with_alias=False, **kwargs) | |
| 1151 | + | p.get_sql(with_alias=True, **kwargs) | |
| 1152 | 1152 | if hasattr(p, "get_sql") | |
| 1153 | 1153 | else str(p) | |
| 1154 | 1154 | for p in self.args |
The check that tells the two apart
fail→pass·pypika/tests/test_selects.py::AliasTests::test_function_using_as_nested
Check file pypika/tests/test_selects.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before itcce2435b101870d6b82b2c80bd8a4d96bc6aaf93
Broken version dated2020-03-31
Modulepypika.terms
Units changedFunction
Fingerprinte52ce3b93deb4376
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in kayak/pypika
- 2024-04-17fix `Field.__init__` (#742)
- 2023-09-26Fix: Allow the usage of `frozenset` in the `isin(...)` and `notin(...)` functions (#744)
- 2023-09-22fix(terms): fixed EmptyCriterion bug with ComplexCriterion (#732)
- 2021-08-26MySQLQuery
- 2021-01-11Fix empty Postgres array syntax (#539)
- 2021-01-04Fix PostgreSQLQueryBuilder returning clause code causing Py3.9 test failures