Whole file
pycqa/flake8
The author described this change as “Remediate one wafer thing decision logic bug”. It counts as a record because the check below fails on the code as it stood at 0239f15dc and passes on a44a09f87, with nothing else changed between the two runs.
Projectpycqa/flake8
Fix saved2017-07-28
Sharing licenceMIT · LICENSE
Change size+3 −0
What the code was meant to do, written into the code itself as a save note
Remediate one wafer thing decision logic bug
The change
| 263 | 263 | if (select is None and | |
| 264 | 264 | (extra_select is None or not self.using_default_ignore)): | |
| 265 | 265 | return Decision.Ignored | |
| 266 | + | if ((select is None and not self.using_default_select) and | |
| 267 | + | (ignore is None and self.using_default_ignore)): | |
| 268 | + | return Decision.Ignored | |
| 266 | 269 | return Decision.Selected | |
| 267 | 270 | ||
| 268 | 271 | def make_decision(self, code): |
The check that tells the two apart
fail→pass·tests/unit/test_decision_engine.py::test_more_specific_decision_for_logic[select19-ignore19-extend_select19-enabled_extensions19-I101-Decision.Ignored]
Check file tests/unit/test_decision_engine.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it0239f15dcce323357f316a66225b0d4d2308de28
Broken version dated2017-07-27
Moduleflake8.style_guide
Units changedDecisionEngine
Fingerprintffc568514bde6cf8
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in pycqa/flake8
- 2022-11-08load_config
- 2021-12-24fix AttributeError when catatstrophic failure is triggered
- 2016-02-20Notifier
- 2015-12-29Fix logic for Notifier.listeners_for