Whole file
bastikr/boolean.py
The author described this change as “Fix absorption issue #113 #112 #111”. It counts as a record because the check below fails on the code as it stood at 431e5226c and passes on 228f005f2, with nothing else changed between the two runs.
Projectbastikr/boolean.py
Fix saved2024-11-15
Sharing licenceBSD-2-Clause · LICENSE.txt
Change size+6 −1
What the code was meant to do, written into the code itself as a save note
Fix absorption issue #113 #112 #111
The change
| 1491 | 1491 | i -= 1 | |
| 1492 | 1492 | continue | |
| 1493 | 1493 | else: | |
| 1494 | - | args[j] = b | |
| 1494 | + | if b in args: | |
| 1495 | + | del args[j] | |
| 1496 | + | if j < i: | |
| 1497 | + | i -= 1 | |
| 1498 | + | else: | |
| 1499 | + | args[j] = b | |
| 1495 | 1500 | j += 1 | |
| 1496 | 1501 | continue | |
| 1497 | 1502 |
The check that tells the two apart
fail→pass·boolean/test_boolean.py::DualBaseTestCase::test_absorption_invariant_to_order
Check file boolean/test_boolean.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it431e5226c269e4c863cc851b971ca5e89fda04d7
Broken version dated2022-06-04
Moduleboolean.boolean
Units changedDualBase
Fingerprint327ccfcf29deb3e4
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in bastikr/boolean.py
- 2017-01-10Fix bug in normalize and write tests.
- 2016-05-13Fix for #45 Do not simplify() by default
- 2016-03-27Fix bug in remove where an undefined variable was used.
- 2012-06-05Fix bug in DualBase.eval