Whole file
bastikr/boolean.py
The author described this change as “Fix bug in remove where an undefined variable was used.”. It counts as a record because the check below fails on the code as it stood at 4fe3c828b and passes on 8834e8a77, with nothing else changed between the two runs.
Projectbastikr/boolean.py
Fix saved2016-03-27
Sharing licenceBSD-2-Clause · LICENSE.txt
Change size+1 −1
What the code was meant to do, written into the code itself as a save note
Fix bug in remove where an undefined variable was used.
The change
| 873 | 873 | args = list(self.args) | |
| 874 | 874 | args.remove(expr) | |
| 875 | 875 | elif isinstance(expr, self.__class__): | |
| 876 | - | if all(arg in self.args for arg in item.args): | |
| 876 | + | if all(arg in self.args for arg in expr.args): | |
| 877 | 877 | args = tuple(arg for arg in self.args if arg not in expr) | |
| 878 | 878 | if len(args) == 0: | |
| 879 | 879 | return None |
The check that tells the two apart
fail→pass·boolean/test_boolean.py::DualBaseTestCase::test_remove
Check file boolean/test_boolean.py, taken without changes from the fix and copied onto the older code, so the exact same check runs against both versions.
Origin and history
The code before it4fe3c828b6a21dd011df8f66ee2018f9a652a2ba
Broken version dated2016-03-27
Moduleboolean.boolean
Units changedDualBase
Fingerprintad2fb4c2abc463e5
Checked2026-08-18 by goldset/0.1
Every field above is generated by our program. None of it is written by hand.
Other bugs found in bastikr/boolean.py
- 2024-11-15Fix absorption issue #113 #112 #111
- 2017-01-10Fix bug in normalize and write tests.
- 2016-05-13Fix for #45 Do not simplify() by default
- 2012-06-05Fix bug in DualBase.eval